Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable FTL device randomization for Android and iOS. #924

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Enable FTL device randomization for Android and iOS. #924

merged 1 commit into from
Jan 16, 2024

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jan 10, 2024 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Update matrix script to allow multiple FTL devices of each type, and update to a newer firebase-test-lab action that allows randomizing devices.

Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/7494588317/job/20405319450#step:11:120

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@jonsimantov jonsimantov requested a review from a-maurice January 11, 2024 19:27
@jonsimantov
Copy link
Contributor Author

You can see the device randomization working here: https://github.com/firebase/firebase-unity-sdk/actions/runs/7494588317/job/20405319450#step:11:120

@jonsimantov jonsimantov marked this pull request as ready for review January 12, 2024 18:52
@jonsimantov jonsimantov changed the title First pass at device randomization. Enable FTL device randomization for Android and iOS. Jan 12, 2024
@jonsimantov jonsimantov merged commit 3d2cea3 into main Jan 16, 2024
8 of 15 checks passed
@firebase firebase locked and limited conversation to collaborators Feb 16, 2024
@a-maurice a-maurice deleted the android-device-randomization branch May 8, 2024 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

@a-maurice a-maurice Awaiting requested review from a-maurice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @cynthiajoan